Skip to content

Update compiler-plugins.md #21796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Update compiler-plugins.md #21796

merged 1 commit into from
Feb 26, 2025

Conversation

xuwei-k
Copy link
Contributor

@xuwei-k xuwei-k commented Oct 17, 2024

can't enable ResearchPlugin if add -experimental option.

@bishabosha
Copy link
Member

this does raise the question of if research plugins perhaps should be enabled if there is -experimental - i.e. which poison pills the API anyway from being used in stable

@hamzaremmal
Copy link
Member

hamzaremmal commented Feb 21, 2025

I agree with Jamie, now that we can make this clearer, I believe we should.
@Gedochao, can you please add it to the agenda of next week's core meeting.
The question raised here is: Should we allow Research Plugins under -experimental ?

@hamzaremmal hamzaremmal added the stat:needs decision Some aspects of this issue need a decision from the maintainance team. label Feb 21, 2025
@tgodzik
Copy link
Contributor

tgodzik commented Feb 24, 2025

I agree with Jamie, now that we can make this clearer, I believe we should. @Gedochao, can you please add it to the agenda of next week's core meeting. The question raised here is: Should we allow Research Plugins under -experimental ?

Do you want to join the core meeting? @hamzaremmal ?

@hamzaremmal
Copy link
Member

I agree with Jamie, now that we can make this clearer, I believe we should. @Gedochao, can you please add it to the agenda of next week's core meeting. The question raised here is: Should we allow Research Plugins under -experimental ?

Do you want to join the core meeting? @hamzaremmal ?

Nope, it's self explanatory.

@tgodzik
Copy link
Contributor

tgodzik commented Feb 26, 2025

I agree with Jamie, now that we can make this clearer, I believe we should. @Gedochao, can you please add it to the agenda of next week's core meeting. The question raised here is: Should we allow Research Plugins under -experimental ?

During the core meeting we decided that there is no reason to do it proactively. We could enable it under experimental if someone reaches out explicitly and asks for it. Though in that case we would most likely need some arguments in favour to be convinced.

@hamzaremmal hamzaremmal merged commit 399d008 into main Feb 26, 2025
50 checks passed
@hamzaremmal hamzaremmal deleted the compiler-plugins-document branch February 26, 2025 16:30
@tgodzik tgodzik removed the stat:needs decision Some aspects of this issue need a decision from the maintainance team. label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants